Skip to content

style: clean up some imports#3179

Merged
elijah-potter merged 2 commits into
Automattic:masterfrom
86xsk:cleanup-imports
May 14, 2026
Merged

style: clean up some imports#3179
elijah-potter merged 2 commits into
Automattic:masterfrom
86xsk:cleanup-imports

Conversation

@86xsk
Copy link
Copy Markdown
Contributor

@86xsk 86xsk commented Apr 15, 2026

Description

Clean up some imports, mostly by merging and reordering.

Recreated/extracted from #2630, with the intent to (slightly) reduce its size. I initially expected this to be larger, but I realized some of the import cleanups in #2630 are questionable, and are probably best undone instead.

How Has This Been Tested?

  • cargo check

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

Clean up some imports, mostly by merging and reordering.
Copy link
Copy Markdown
Collaborator

@hippietrail hippietrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this clean style.

elijah-potter
elijah-potter previously approved these changes May 8, 2026
Copy link
Copy Markdown
Collaborator

@elijah-potter elijah-potter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this is much better. It looks like the failing check is just an example of the issue I'm trying to fix with #3328.

@elijah-potter elijah-potter enabled auto-merge May 14, 2026 19:01
@elijah-potter elijah-potter added this pull request to the merge queue May 14, 2026
Merged via the queue into Automattic:master with commit 668eac0 May 14, 2026
13 checks passed
@86xsk 86xsk deleted the cleanup-imports branch May 17, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants