style: clean up some imports#3179
Merged
Merged
Conversation
Clean up some imports, mostly by merging and reordering.
hippietrail
approved these changes
Apr 15, 2026
Collaborator
hippietrail
left a comment
There was a problem hiding this comment.
I like this clean style.
elijah-potter
previously approved these changes
May 8, 2026
Collaborator
elijah-potter
left a comment
There was a problem hiding this comment.
I agree, this is much better. It looks like the failing check is just an example of the issue I'm trying to fix with #3328.
elijah-potter
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up some imports, mostly by merging and reordering.
Recreated/extracted from #2630, with the intent to (slightly) reduce its size. I initially expected this to be larger, but I realized some of the import cleanups in #2630 are questionable, and are probably best undone instead.
How Has This Been Tested?
cargo checkChecklist