fix(harper-typst): crash#3366
Merged
Merged
Conversation
elijah-potter
force-pushed
the
feature/typst-crash
branch
from
62272a0 to
fb7399e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2126
Description
This fixes a Typst parser crash caused by
#show "a": "a"emitting show-rule tokens out of source order. The translator now parses the show-rule selector before the transform so downstream linters receive monotonically ordered spans andRepeatedWordsno longer tries to construct an invalid span.A regression test covers the reported input and asserts that the emitted token spans preserve source order.
How Has This Been Tested?
Additional unit tests
Checklist