fix(core): refine BetterOffPhrase contexts#3376
Merged
elijah-potter merged 2 commits intoMay 15, 2026
Merged
Conversation
hippietrail
suggested changes
May 13, 2026
| @@ -26,6 +30,12 @@ test "Of course this is better overall." "Of course this is better overall." | |||
| test "He offered better outcomes, not quick fixes." "He offered better outcomes, not quick fixes." | |||
Collaborator
There was a problem hiding this comment.
Oh you can use allows followed by just one copy of the sentence.
It's a bit newer than using test followed by two copies, so there are still linters in the repo using it.
elijah-potter
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BetterOffPhraseso it still catches clearbetter of→better offadjective/adverbial contexts from the issue.Duplicate / spam checks
2863,better of, andbetter off; no duplicate found.Verification
rustup run stable cargo fmt --checkrustup run stable cargo test -p harper-core run_tests_for_better_off_phrase --librustup run stable cargo test -p harper-core --lib(5307 passed, 264 ignored)git diff --check