Skip to content

fix(core): refine BetterOffPhrase contexts#3376

Merged
elijah-potter merged 2 commits into
Automattic:masterfrom
cfcryptotrader-rgb:cfcryptotrader-issue-2863
May 15, 2026
Merged

fix(core): refine BetterOffPhrase contexts#3376
elijah-potter merged 2 commits into
Automattic:masterfrom
cfcryptotrader-rgb:cfcryptotrader-issue-2863

Conversation

@cfcryptotrader-rgb
Copy link
Copy Markdown
Contributor

Summary

Duplicate / spam checks

Verification

  • rustup run stable cargo fmt --check
  • rustup run stable cargo test -p harper-core run_tests_for_better_off_phrase --lib
  • rustup run stable cargo test -p harper-core --lib (5307 passed, 264 ignored)
  • git diff --check

Copy link
Copy Markdown
Collaborator

@hippietrail hippietrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not good at more advanced Weir but if all those tests are passing it's probably ready. I did point out that you can use allows for the negative tests.

@@ -26,6 +30,12 @@ test "Of course this is better overall." "Of course this is better overall."
test "He offered better outcomes, not quick fixes." "He offered better outcomes, not quick fixes."
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you can use allows followed by just one copy of the sentence.
It's a bit newer than using test followed by two copies, so there are still linters in the repo using it.

@elijah-potter elijah-potter added this pull request to the merge queue May 15, 2026
Merged via the queue into Automattic:master with commit 59f4849 May 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False negative: "better of" is not flagged as a typo for "better off"

3 participants