feat(core): allow scope config in Weir rules#3382
Merged
Merged
Conversation
elijah-potter
force-pushed
the
feature/SentenceWeir
branch
from
08f45c2 to
fd01ca0
Compare
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
This PR adds a new setting within a Weir rule:
scope. It allows rule authors to select which scope the rule runs in. There are two options: "Chunk" (which is the default) and "Sentence". The former only investigate within chunk boundaries while the latter only for sentence boundaries.See the edited documentation in the diff for more details.
How Has This Been Tested?
Additional unit tests.
Checklist