Skip to content

fix: avoid BuiltIn false positive for verb phrases#3460

Merged
elijah-potter merged 1 commit into
Automattic:masterfrom
jmolz:fix-built-in-verb-phrase
May 25, 2026
Merged

fix: avoid BuiltIn false positive for verb phrases#3460
elijah-potter merged 1 commit into
Automattic:masterfrom
jmolz:fix-built-in-verb-phrase

Conversation

@jmolz
Copy link
Copy Markdown
Contributor

@jmolz jmolz commented May 21, 2026

Fixes #3288

Summary

  • narrow the BuiltIn Weir rule so built in only lints in modifier+noun contexts
  • add regression coverage for verb-phrase uses like "was built in 1962" and "was built in Rust"
  • keep existing in-built and modifier suggestions covered

Tests

  • cargo test -p harper-core run_tests_for_built_in
  • cargo run -p harper-cli -- test harper-core/src/linting/weir_rules/BuiltIn.weir
  • cargo fmt --all --check

@elijah-potter
Copy link
Copy Markdown
Collaborator

This looks good to me. Thanks!

@elijah-potter elijah-potter added this pull request to the merge queue May 25, 2026
Merged via the queue into Automattic:master with commit 83e1e50 May 25, 2026
14 checks passed
@jmolz jmolz deleted the fix-built-in-verb-phrase branch May 26, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive: "built in" flagged to be hyphenated when the words should remain separate

2 participants