Skip to content

feat(core): create rule to add accent to cliche#3494

Merged
elijah-potter merged 4 commits into
masterfrom
feature/cliche
May 26, 2026
Merged

feat(core): create rule to add accent to cliche#3494
elijah-potter merged 4 commits into
masterfrom
feature/cliche

Conversation

@elijah-potter
Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

Adds a new Weir spelling rule, ClicheAccent, that suggests cliché when users write cliche without the accent.

The rule is enabled in the curated default config under Spelling and Orthography.

Demo

N/A

How Has This Been Tested?

Added Weir rule tests covering lowercase, uppercase, sentence-initial, punctuation-adjacent, and hyphenated uses of cliche, plus allowed cases for the already-accented spelling and nearby non-matches.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@hippietrail
Copy link
Copy Markdown
Collaborator

There's no way in Weir at this stage to get this to also cover the plural in a single rule is there?

@elijah-potter
Copy link
Copy Markdown
Collaborator Author

I've adjusted the build step for the weir_rules directory. You should be able to compose multiple Weir rules into a single one by placing them into a subfolder together.

Take a look at the diff.

@hippietrail
Copy link
Copy Markdown
Collaborator

I've adjusted the build step for the weir_rules directory. You should be able to compose multiple Weir rules into a single one by placing them into a subfolder together.

Take a look at the diff.

That, sir, is very awesome!

@elijah-potter elijah-potter added this pull request to the merge queue May 26, 2026
Merged via the queue into master with commit df18ff1 May 26, 2026
13 checks passed
@elijah-potter elijah-potter deleted the feature/cliche branch May 26, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants