feat: desktop get locale/dialect from Tauri#3509
Merged
elijah-potter merged 4 commits intoMay 28, 2026
Merged
Conversation
Collaborator
Author
elijah-potter
requested changes
May 26, 2026
Collaborator
elijah-potter
left a comment
There was a problem hiding this comment.
This is exactly how I would have gone about this. Thank you! I just have one nit.
| } | ||
| } | ||
| // BCP-47 https://www.rfc-editor.org/rfc/rfc5646 | ||
| #[must_use] |
Collaborator
There was a problem hiding this comment.
This annotation is not necessary.
Collaborator
Author
There was a problem hiding this comment.
At first I thought you meant the comment. I didn't really get what #[must_use] does and asked an AI if this function need one too. So much for that d-:
| } | ||
| } | ||
|
|
||
| pub fn detect_system_dialect() -> Dialect { |
elijah-potter
approved these changes
May 27, 2026
Collaborator
elijah-potter
left a comment
There was a problem hiding this comment.
Looks great! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Closes #3501
Description
Sets the
Dialectfor Harper Desktop from the system using the official Tauri method.How Has This Been Tested?
cargo testjust build-desktop-macosthen installing the newly build app, running it, going into prefs, and seeing this:AI Disclosure
Actually I used Google AI to help choose which method to use and to finesse the code to something tiny and Rusty.
Checklist