Skip to content

fix: closure checking apostrophe confusingly named is_tack#3511

Merged
elijah-potter merged 1 commit into
Automattic:masterfrom
hippietrail:rename-is-tack-in-lex-word
May 26, 2026
Merged

fix: closure checking apostrophe confusingly named is_tack#3511
elijah-potter merged 1 commit into
Automattic:masterfrom
hippietrail:rename-is-tack-in-lex-word

Conversation

@hippietrail
Copy link
Copy Markdown
Collaborator

@hippietrail hippietrail commented May 26, 2026

Issues

N/A

Description

I was going to work on some more mixups between "tack" and "tact" but while grepping for existing logic doing this I happened across a closure named is_tack() inside lex_word() in lexing/mod.rs Apparently this came about in one of the commits that made up the Weir PR: 46f4547

The closure actually checks for presence of an apostrophe. I'm guessing this was a typo for "tick" given that ` is often called "backtick" though Googling for whether anyone also calls ' "tick" I couldn't find any evidence of that. So I've just changed it to the most vanilla / least confusing name is_apostrophe()

The only benefit of this bikeshedding change is that it won't be a red herring again for anyone else working on "tact" vs "tack" in the future (-:

Demo

N/A

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@elijah-potter elijah-potter added this pull request to the merge queue May 26, 2026
Merged via the queue into Automattic:master with commit 8e28586 May 26, 2026
13 checks passed
@hippietrail hippietrail deleted the rename-is-tack-in-lex-word branch May 26, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants