Skip to content

refactor: tweak two phrase set corrections#3512

Merged
elijah-potter merged 1 commit into
Automattic:masterfrom
hippietrail:tweak-two-phrase-corrections
May 26, 2026
Merged

refactor: tweak two phrase set corrections#3512
elijah-potter merged 1 commit into
Automattic:masterfrom
hippietrail:tweak-two-phrase-corrections

Conversation

@hippietrail
Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

While looking into a new phrase set correction I noticed two ones I recently added that weren't quite right. Both just had single corrections rather than sets.

  • One, InHindsight was moved to a Weir rule.
  • The other, ArgumentToBeMade was extended to cover plural as well as singular.

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

Both just has single corrections rather than sets.
- One was moved to a Weir rule.
- The other was extended to cover plural as well as singular.
@elijah-potter elijah-potter added this pull request to the merge queue May 26, 2026
Merged via the queue into Automattic:master with commit d8f6796 May 26, 2026
13 checks passed
@hippietrail hippietrail deleted the tweak-two-phrase-corrections branch May 26, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants