Skip to content

fix(desktop): remove second Dock icon#3515

Merged
elijah-potter merged 2 commits into
masterfrom
feature/dupe-window
May 28, 2026
Merged

fix(desktop): remove second Dock icon#3515
elijah-potter merged 2 commits into
masterfrom
feature/dupe-window

Conversation

@elijah-potter
Copy link
Copy Markdown
Collaborator

Issues

Fixes #3499

Description

Prevents the Harper Desktop highlighter helper from appearing as a second macOS app.

The highlighter runs in a child process with its own winit event loop. On macOS, that made the helper process show up separately in the Dock/app switcher with the default minimal app menu. This updates the highlighter event-loop setup to use macOS accessory activation policy and disables the default highlighter process menu, while leaving the main Harper Desktop app behavior unchanged.

Demo

N/A

How Has This Been Tested?

Manually.

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

Copy link
Copy Markdown
Collaborator

@hippietrail hippietrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. I never used winit but in a native AppKit app it's the activation policy.

@elijah-potter elijah-potter enabled auto-merge May 28, 2026 20:59
@elijah-potter elijah-potter added this pull request to the merge queue May 28, 2026
Merged via the queue into master with commit a1429d8 May 28, 2026
13 checks passed
@elijah-potter elijah-potter deleted the feature/dupe-window branch May 28, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Launching Map desktop app via "Apps", Spotlight, or Terminal shell, launches two copies

2 participants