Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

Conversation

@ockham
Copy link
Contributor

@ockham ockham commented Nov 11, 2017

Broken out of #11.

To test:

  • rm -r node_modules/
  • npm install
  • grep version node_modules/react/package.json (should return 16.something)
  • npm run test should pass

@samouri
Copy link

samouri commented Nov 13, 2017

I followed the testing instructions and everything lgtm.
CircleCI is upset for reasons that I doubt are relevant to this PR:

Warning: Permanently added the RSA host key for IP address '192.30.253.112' to the list of known hosts.

Permission denied (publickey).

fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

git command i returned 128: 

I've opened an issue for it but feel free to 🚢 in the meantime

Copy link

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to update package.json!

@ockham
Copy link
Contributor Author

ockham commented Nov 15, 2017

also need to update package.json!

The package version you mean? Yeah, wasn't sure about immediately releasing vs trying to also get #11 in, but then again, let's not get blocked by that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants