Skip to content

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jul 7, 2023

Proposed changes:

This should be the final step to enable the new Blaze dashboard to all self-hosted site owners.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Start with a self-hosted site that's connected to WordPress.com.
  • You should now see a Tools > Advertising menu in wp-admin.
  • When clicking on it, you should be directed to the Blaze dashboard.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/blaze-dashboard-default branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/blaze-dashboard-default
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: August 1, 2023.
  • Scheduled code freeze: July 25, 2023.

@jeherve jeherve added [Status] Needs Review This PR is ready for review. [Status] Needs Testing We need to add this change to the testing call for this month's release [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed DO NOT MERGE don't merge it! [Status] Blocked / Hold labels Jul 20, 2023
@jeherve jeherve added this to the jetpack/12.4 milestone Jul 20, 2023
@jeherve jeherve enabled auto-merge (squash) July 20, 2023 07:28
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jul 20, 2023
Copy link
Contributor

@sbarbosa sbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked great! 👍
I tested it on Simple, Atomic, and self-hosted sites and got the expected behavior.
Thanks for the change!

@jeherve jeherve merged commit 2fcfb35 into trunk Jul 20, 2023
@jeherve jeherve deleted the update/blaze-dashboard-default branch July 20, 2023 12:50
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 20, 2023
jeherve added a commit that referenced this pull request Jul 27, 2023
This is a follow-up to #31617 and #31750.

We now have Blaze::enable_blaze_menu() to add the Blaze menu to wp-admin whenever necessary. However, Jetpack sites still rely on the admin-menu endpoint to display a list of custom menu items in Calypso. There, we'll want to always display the Tools > Advertising menu item, as long as the site is eligible for Blaze.
@sdixon194 sdixon194 removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Blaze [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants