Blaze: always display menu in Calypso for Jetpack sites

[jeherve]

Proposed changes:

This is a follow-up to #31617 and #31750.

We now have Blaze::enable_blaze_menu() to add the Blaze menu to wp-admin whenever necessary. However, Jetpack sites still rely on the admin-menu endpoint to display a list of custom menu items in Calypso. There, we'll want to always display the Tools > Advertising menu item, as long as the site is eligible for Blaze.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

This was reported in p1690392457355839-slack-C0351BKR0M6

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

You will want to test this in all environments (simple, WoA, Pressable, self-hosted) to ensure this works well, and that no environment includes a duplicate Advertising menu.

1. Go to https://wordpress.com/stats/day/yoursite.com
2. You should see a Tools > Advertising if your site is public.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the fix/missing-advertising-menu-jetpack-calypso branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/missing-advertising-menu-jetpack-calypso
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

• Next scheduled release: August 23, 2023.
• Scheduled code freeze: August 15, 2023.

[samiff]

✅ Simple wpcom
✅ WoA
✅ Pressable
✅ Self-hosted

[zinigor]

Cherry picked into 12.4 in 4a1a63f.