Skip to content

Conversation

sgomes
Copy link
Contributor

@sgomes sgomes commented Jul 24, 2023

Proposed changes:

In an effort to move away from the devicepx script towards native functionality, this PR adds a srcset to related posts thumbnails (the block, not the module feature). The browser will automatically pick the most appropriate image from the options in the srcset, depending on the screen pixel ratio and the current zoom value.

  • Add srcset to the related posts block thumbnails
  • Add 1.5x multiplier, because this is an extremely common screen density

This PR complements #31432, by dealing with the related posts block instead of the module feature, this time.

Other information:

  • N/A Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Add a "Related Posts" block to your test post, and ensure that it can find at least 3 related posts.
  • Enable thumbnails in the block options.
  • Visit the post.
  • Verify that the thumbnails include a srcset with different pixel ratios (up to 4x, if the source image is large enough).

@sgomes sgomes added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Performance [Status] Needs Review This PR is ready for review. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Block] Related Posts labels Jul 24, 2023
@sgomes sgomes requested review from jeherve and a team July 24, 2023 09:59
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/add-srcset-to-related-posts-block branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/add-srcset-to-related-posts-block
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: August 23, 2023.
  • Scheduled code freeze: August 15, 2023.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 26, 2023
@sgomes sgomes enabled auto-merge (squash) July 26, 2023 10:09
@sgomes
Copy link
Contributor Author

sgomes commented Jul 26, 2023

Thank you for the review, @jeherve! 🙌

@sgomes sgomes merged commit 10c3a39 into trunk Jul 26, 2023
@sgomes sgomes deleted the update/add-srcset-to-related-posts-block branch July 26, 2023 10:12
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 26, 2023
@github-actions github-actions bot added this to the jetpack/12.5 milestone Jul 26, 2023
chrismccluskey pushed a commit that referenced this pull request Aug 1, 2023
Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
haqadn pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Related Posts [Feature] Related Posts [Focus] Performance [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants