Skip to content

Related posts block: add srcset to thumbnails #32026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Related posts block: add srcset to thumbnails #32026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
685e91e
Related posts block: add srcset to thumbnails
sgomes Jul 24, 2023
e61109c
Merge remote-tracking branch 'origin/trunk' into update/add-srcset-to…
jeherve Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/update-add-srcset-to-related-posts-block
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: enhancement

Related posts block: add srcset to thumbnails
3 changes: 1 addition & 2 deletions projects/plugins/jetpack/class.jetpack-post-images.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,10 +741,9 @@ public static function generate_cropped_srcset( $image, $base_width, $base_heigh
return $srcset;
}

$multipliers = array( 1, 2, 3, 4 );
$multipliers = array( 1, 1.5, 2, 3, 4 );
$srcset_values = array();
foreach ( $multipliers as $multiplier ) {
// Forcefully cast to int, in case we ever add decimal multipliers.
$srcset_width = (int) ( $base_width * $multiplier );
$srcset_height = (int) ( $base_height * $multiplier );
if ( $srcset_width < 1 || $srcset_width > $image['src_width'] ) {
Expand Down
7 changes: 4 additions & 3 deletions projects/plugins/jetpack/modules/related-posts/jetpack-related-posts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ public function get_client_rendered_html_unsupported() {
/**
* Echoes out items for the Gutenberg block
*
* @param array $related_post The post oject.
* @param array $related_post The post object.
* @param array $block_attributes The block attributes.
*/
public function render_block_item( $related_post, $block_attributes ) {
Expand All @@ -382,13 +382,14 @@ public function render_block_item( $related_post, $block_attributes ) {

if ( ! empty( $block_attributes['show_thumbnails'] ) && ! empty( $related_post['img']['src'] ) ) {
$img_link = sprintf(
'<li class="jp-related-posts-i2__post-img-link"><a href="%1$s" %2$s><img src="%3$s" width="%4$s" height="%5$s" alt="%6$s" loading="lazy" /></a></li>',
'<li class="jp-related-posts-i2__post-img-link"><a href="%1$s" %2$s><img loading="lazy" src="%3$s" width="%4$s" height="%5$s" alt="%6$s" %7$s/></a></li>',
esc_url( $related_post['url'] ),
( ! empty( $related_post['rel'] ) ? 'rel="' . esc_attr( $related_post['rel'] ) . '"' : '' ),
esc_url( $related_post['img']['src'] ),
esc_attr( $related_post['img']['width'] ),
esc_attr( $related_post['img']['height'] ),
esc_attr( $related_post['img']['alt_text'] )
esc_attr( $related_post['img']['alt_text'] ),
( ! empty( $related_post['img']['srcset'] ) ? 'srcset="' . esc_attr( $related_post['img']['srcset'] ) . '"' : '' )
);

$item_markup .= $img_link;
Expand Down