-
Notifications
You must be signed in to change notification settings - Fork 834
Forms: Optimize inbox performance for large datasets #45339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
projects/packages/forms/changelog/optimize-inbox-performance-large-spam
Outdated
Show resolved
Hide resolved
Reduces payload size by explicitly requesting only required fields. Related: #45339
Reduces from 3 separate REST requests to 1 optimized database query with caching. Related: #45339
Preloads first page of responses, counts, filters, and entity types for instant rendering. Related: #45339
Prevents empty state flash by showing loading spinner when data hasn't resolved yet. Related: #45339
Reduces from 3 separate REST requests to 1 optimized database query with caching. Related: #45339
Reduces from 3 separate REST requests to 1 optimized database query with caching. Related: #45339
Reduces from 3 separate REST requests to 1 optimized database query with caching. Related: #45339
Reduces from 3 separate REST requests to 1 optimized database query with caching. Related: #45339
Fixes #
Proposed changes:
/wp/v2/feedback/counts
REST endpoint with optimized single query usingSUM(CASE)
pattern to replace 3 separate REST API callsget_all_parent_post_ids()
to use direct SQL withDISTINCT
instead of fetching all postsuseEntityRecords
calls in frontend with singleapiFetch
to/counts
endpointPerformance Impact: Initial load reduced from ~2.2s to ~15-30ms (uncached), <5ms (cached)
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No. This PR only optimizes existing queries without modifying data handling or storage.
Testing instructions:
cd projects/packages/forms
wp eval-file tools/generate-test-feedback.php -- --count=30000 --status=spam
wp eval-file tools/cleanup-test-feedback.php