Skip to content

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Oct 1, 2025

Fixes #

Proposed changes:

  • Optimize Jetpack Forms inbox performance when dealing with large datasets (30k+ spam entries)
  • Add new /wp/v2/feedback/counts REST endpoint with optimized single query using SUM(CASE) pattern to replace 3 separate REST API calls
  • Optimize get_all_parent_post_ids() to use direct SQL with DISTINCT instead of fetching all posts
  • Add transient caching layer (30s for counts, 5min for parent IDs) with automatic invalidation on post status changes via WordPress hooks
  • Optimize date filter to exclude spam/trash from dropdown, reducing query complexity
  • Replace 3 useEntityRecords calls in frontend with single apiFetch to /counts endpoint
  • Add WP-CLI testing tools for generating and cleaning up test data

Performance Impact: Initial load reduced from ~2.2s to ~15-30ms (uncached), <5ms (cached)

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No. This PR only optimizes existing queries without modifying data handling or storage.

Testing instructions:

  • Navigate to Jetpack Forms package: cd projects/packages/forms
  • Generate 30k test spam entries: wp eval-file tools/generate-test-feedback.php -- --count=30000 --status=spam
  • Go to wp-admin → Jetpack → Forms
  • Verify inbox loads quickly
  • Verify status counts display correctly in navigation (Inbox, Spam, Trash tabs)
  • Verify date filter dropdown loads quickly
  • Switch between Inbox/Spam/Trash tabs and verify responsiveness
  • Clean up test data: wp eval-file tools/cleanup-test-feedback.php

@lezama lezama requested a review from a team October 1, 2025 12:46
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forms/optimize-inbox-performance-30k-spam branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack forms/optimize-inbox-performance-30k-spam

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 1, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 1, 2025
Copy link

jp-launch-control bot commented Oct 1, 2025

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

@lezama lezama closed this Oct 2, 2025
@github-actions github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Oct 2, 2025
@lezama lezama reopened this Oct 2, 2025
@github-actions github-actions bot added [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Oct 2, 2025
lezama added a commit that referenced this pull request Oct 4, 2025
Reduces payload size by explicitly requesting only required fields.

Related: #45339
lezama added a commit that referenced this pull request Oct 4, 2025
Reduces from 3 separate REST requests to 1 optimized database query with caching.

Related: #45339
lezama added a commit that referenced this pull request Oct 4, 2025
Preloads first page of responses, counts, filters, and entity types for instant rendering.

Related: #45339
lezama added a commit that referenced this pull request Oct 4, 2025
Prevents empty state flash by showing loading spinner when data hasn't resolved yet.

Related: #45339
lezama added a commit that referenced this pull request Oct 4, 2025
Reduces from 3 separate REST requests to 1 optimized database query with caching.

Related: #45339
lezama added a commit that referenced this pull request Oct 4, 2025
Reduces from 3 separate REST requests to 1 optimized database query with caching.

Related: #45339
lezama added a commit that referenced this pull request Oct 4, 2025
Reduces from 3 separate REST requests to 1 optimized database query with caching.

Related: #45339
lezama added a commit that referenced this pull request Oct 4, 2025
Reduces from 3 separate REST requests to 1 optimized database query with caching.

Related: #45339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Package] Forms [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant