Skip to content

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Oct 4, 2025

Summary

Replaces 3 separate REST API requests for status counts (inbox/spam/trash) with a single optimized database query.

Changes

  • Added /wp/v2/feedback/counts REST endpoint with optimized single-query count logic
  • Added caching (30s transient) for counts
  • Updated use-inbox-data to use new endpoint instead of 3 useEntityRecords calls

Performance Impact

  • Reduces from 3 REST requests to 1
  • Single DB query vs 3 separate queries
  • 30s cache reduces server load

Related

Main PR: #45339

Copy link
Contributor

github-actions bot commented Oct 4, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • 🔴 Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 4, 2025
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forms/optimize-inbox-counts branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack forms/optimize-inbox-counts

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link

jp-launch-control bot commented Oct 4, 2025

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

@lezama lezama force-pushed the forms/optimize-inbox-counts branch 3 times, most recently from e54a6cf to b6171a4 Compare October 4, 2025 12:58
Reduces from 3 separate REST requests to 1 optimized database query with caching.

Related: #45339
@lezama lezama force-pushed the forms/optimize-inbox-counts branch from b6171a4 to 26457a8 Compare October 4, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Package] Forms [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant