-
Notifications
You must be signed in to change notification settings - Fork 834
Use Title Case consistently in card titles, to match Calypso #6172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Those are using the module name as is defined in the module file header. Would you prefer to update the module file or add a custom, no capitalized, string in JS? Note that if the module file header, for example, |
From what I can tell, every heading in Calypso uses title case, while every option/label uses sentence case. I think we should be matching that, which means we should be ensuring that headings are title case in Jetpack. |
The places that I found which do not already have Title Case (e.g. which would need to be updated) are;
|
Also cleaned up a bunch of linting errors.
import SettingsCard from 'components/settings-card'; | ||
import SettingsGroup from 'components/settings-group'; | ||
import { SettingsCard } from 'components/settings-card'; | ||
import { SettingsGroup } from 'components/settings-group'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beaulebens this change was causing a major JS error on Writing tab. I've reverted it to the way I wrote it, without the curly braces since the imported component is the default exported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool. I made that change when resolving a conflict, just to match the others. 👍
72a23e4
to
c33ffc8
Compare
c33ffc8
to
cc26a45
Compare
It looks like after a discussion in Slack, we should be using sentence case for all of these headings as per our branding guidelines: https://dotcombrand.wordpress.com/brand-voice/#style Calypso will need to be updated eventually to match. |
Closing this in favor of #6394 since this one was doing title case and we'll be doing sentence case plus it has a bunch of conflicts. |
Changes proposed in this Pull Request:
Testing instructions:
@zinigor @eliorivero or @georgestephanis I couldn't figure out how to change it for all of them. Can one of you fix these: