Fixed concatenated strings and added context where needed. #6410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinigor
added
[Focus] i18n
|
Nice, thank you. |
dereksmart
approved these changes
Feb 15, 2017
dereksmart
added
[Status] Ready to Merge
eliorivero
previously requested changes
Feb 15, 2017
| isCompact={ true } | ||
| > | ||
| { __( 'Updates Needed' ) } | ||
| { __( 'Updates Needed', { context: 'Short warning message' } ) } |
There was a problem hiding this comment.
We agreed on using sentence case instead of title case
| <DashItem className="jp-connection-type" label={ __( 'Site Connection' ) }> | ||
| <DashItem | ||
| className="jp-connection-type" | ||
| label={ __( 'Site Connection', { context: 'Dashboard widget header' } ) } |
| <DashItem className="jp-connection-type" label={ __( 'Account Connection' ) }> | ||
| <DashItem | ||
| className="jp-connection-type" | ||
| label={ __( 'Account Connection', { context: 'Dashboard widget header' } ) } |
_inc/client/pro-status/index.jsx
Outdated
| isCompact={ true } | ||
| > | ||
| { __( 'Invalid Key' ) } | ||
| { __( 'Invalid Key', { context: 'Short warning message about an invalid key being used for Akismet.' } ) } |
eliorivero
added
[Status] In Progress
[Status] Needs Author Reply
|
@eliorivero updated to use sentence case. Merge if LGTY |
dereksmart
added
[Status] Ready to Merge
eliorivero
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some common problems with i18n strings. No major changes here, but still creating a PR to raise awareness about proper use of translation functions :)