Skip to content

Settings UI: update VaultPress notice markup when it's moved into notices area #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2017
Merged

Settings UI: update VaultPress notice markup when it's moved into notices area #6270

merged 2 commits into from
Feb 17, 2017

Conversation

eliorivero
Copy link
Contributor

@eliorivero eliorivero commented Feb 2, 2017 •
edited
Loading

Changes proposed in this Pull Request:

  • updates the markup to match the new one in the dops notice
  • restores 'is-info' status for dev mode notice

before

captura de pantalla 2017-02-15 a las 16 06 25

after

captura de pantalla 2017-02-15 a las 15 51 32

Testing instructions:

  • make sure there is no padding that separates the button from the edge of the notice

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. labels Feb 2, 2017
@eliorivero eliorivero added this to the Settings UI milestone Feb 2, 2017
@eliorivero eliorivero self-assigned this Feb 2, 2017
@eliorivero eliorivero force-pushed the update/vaultpress-in-settings-notice branch from 59bc815 to 7844b95 Compare February 15, 2017 19:20
zinigor
zinigor approved these changes Feb 17, 2017
View reviewed changes
Copy link
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, notices look as expected.

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 17, 2017
@eliorivero eliorivero merged commit c1ea5bf into feature/settings-overhaul Feb 17, 2017
@eliorivero eliorivero deleted the update/vaultpress-in-settings-notice branch February 17, 2017 15:13
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zinigor zinigor zinigor approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@eliorivero eliorivero

Labels
Admin Page React-powered dashboard under the Jetpack menu
Projects
None yet
Milestone
Settings UI
Development

Successfully merging this pull request may close these issues.
2 participants
@eliorivero @zinigor