Skip to content

Settings UI: update VaultPress notice markup when it's moved into notices area #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Settings UI: update VaultPress notice markup when it's moved into notices area #6270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ae61c1
Settings UI: update markup to adapt to changes in notices markup in dops
eliorivero Feb 2, 2017
7844b95
Settings UI: restore status 'is-info' property
eliorivero Feb 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion _inc/client/components/admin-notices/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ const AdminNotices = React.createClass( {
if ( $vpNotice.length > 0 ) {
$vpNotice.each( function () {
let $notice = jQuery( this ).addClass( 'dops-notice is-warning' ).removeClass( 'wrap vp-notice' );
$notice.wrapInner( '<div class="dops-notice__content">' );
$notice.find( 'a' ).addClass( 'dops-notice__action' ).appendTo( $notice );
$notice.find( '.vp-message' ).removeClass( 'vp-message' ).addClass( 'dops-notice__text' );
$notice.find( 'h3' ).replaceWith( function () { return jQuery( '<strong />', { html: this.innerHTML } ); } );
$notice.find( 'p' ).replaceWith( function () { return jQuery( '<div/>', { html: this.innerHTML } ); } );
$notice.prependTo( $adminNotices ).wrapInner( '<div class="dops-notice__content">' ).show();
$notice.prependTo( $adminNotices ).show();
} );
}

Expand Down
2 changes: 1 addition & 1 deletion _inc/client/components/jetpack-notices/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const DevModeNotice = React.createClass( {
return (
<SimpleNotice
showDismiss={ false }
status="is-basic"
status="is-info"
text={ text }
>
<NoticeAction
Expand Down