Settings UI - At a Glance: add link to wpcom in Monitor card #6433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6226
Changes proposed in this Pull Request:
This is how it looks in this PR, which is what @MichaelArestad suggested in #6226
Since this card also has a toggle and there were no instructions about what to do with the toggle, I assumed we should leave it and tested adding a cog icon
This is not in this PR but it's trivial to implement it.
https://wordpress.com/settings/security/%site%
. @beaulebens pointed in Settings: Update Monitor DashItem to link to notification settings in Calypso #6226 that it should point tohttps://wordpress.com/me/notifications
but the referenced issue wasn't implemented so far Notifications: Update the settings to allow control of Jetpack Monitor notifications along with others wp-calypso#11021 and if it was implemented, it would also need a way to go straight into the relevant site, instead of the list of sites. So for now, it's pointed to security.If we keep this, it would be good to have an
id
in the card Jetpack Monitor in Calypso so we can add it to the link and scroll the view straight to that card.removes props siteAdminUrl and siteRawUrl that were passed in cascade (and unused in intermediate components) and instead fetches them in DashItem where they're used.
updates test to reflect that Monitor now has a button in addition to the toggle
Testing instructions:
https://wordpress.com/settings/security/%site%