Settings UI - Non admin: refresh view after unlink. Don't show features if site disconnected

[eliorivero]

Fixes #6464
Fixes #6466 props @oskosk

Changes proposed in this Pull Request:

• remove usage of window.Initial_State.
• if non admin users unlink their accounts, the view is refreshed.
• if site is not connected and user can't do it, show notice prompting user to ask an admin to connect and don't show link button.

Testing instructions:

• Disconnect site and log with non admin: it should display a notice prompting to ask admin to connect the site.
• Disconnect site, the view should be refreshed

[dereksmart]

Previously, the unlinked admin could view stats

This is very much intentional, and I would be hesitant (opposed) to require a connection to view the site stats within the wp-admin. This is the same for the rest of the content that we currently show (and showed before) in the prior UI and also in the wp-admin main dashboard widget.

Non-admins we can be more strict with, but still should make sure we're respecting the stats module options, since admins can choose which roles can see stats.

[eliorivero]

What Derek mentioned has been restored now.

[oskosk]

@eliorivero @dereksmart I think the cause of your headache yesterday is the following

1. With a non-admin linked user, after disconnecting, the <NonAdminView /> component does not update to reflect the unlinked state. The thing is that

<NonAdminView /> is getting isLinked={ true } always among its props passed by its parent (<Main /> )

Even when its parent <Main /> is getting a isLinked={ false } from redux state after unlinking the user.

The problem here is that we used the lifecycle method shouldComponentUpdate() in <Main />.
And this method only returns true on some particular conditions. Changing the link state for a user is not among those conditions.

What this causes is that even when <Main /> knows by its props that the user is now not linked, it doesn't re-render (because shouldComponentUpdate() returns false ) and thus, its children don't get the new props because they're not re-rendered.

Something like this could work:

I've just added a commit, including this condition to the shouldComponentUpdate() method and it looks like it's working as expected.

[eliorivero]

Gracias @oskosk for checking and fixing this! 👍 and the detailed explanation.

[dereksmart]

When I enabled stats to be visible by Editors, I expected to be able to see them, but I'm only seeing a connect page

[dereksmart]

If we're showing a dedicated connect/link page for non-admins, shouldn't we be removing the features from the promotional stuff that includes things they can't activate/deactivate, or may not have access to? Like Photon, Security, Protect, Monitor, Manage, and maybe stats if they're not allowed to see them?

I think that would just leave "Free Support" 😂

[eliorivero]

Updated this PR to do only 2 things: don't show features when site is disconnected (and display a warning prompting user to ask admin to connected) and refresh the view after non admin unlink.

[dereksmart]

Tested, and works as expected, considering the latest changes:

don't show features when site is disconnected (and display a warning prompting user to ask admin to connected) and refresh the view after non admin unlink.

Code looks good. 🐑