special purpose encode/decode for EJS#141
Merged
jrit merged 2 commits intoAutomattic:masterfrom Jul 14, 2015
jrit:cheerio-node-12
Merged
special purpose encode/decode for EJS#141jrit merged 2 commits intoAutomattic:masterfrom jrit:cheerio-node-12
jrit merged 2 commits intoAutomattic:masterfrom
jrit:cheerio-node-12
Conversation
jrit
added a commit
that referenced
this pull request
Jul 14, 2015
special purpose encode/decode for EJS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #140
The underlying issue is with cheerio as referenced here cheeriojs/cheerio#579
An encode/decode step has been added to prevent cheerio from transforming EJS tags. This is based on the solution in the cheerio issue referenced. I'm not sure if this covers every case, but at least resolves the example given in #140 and this CL includes that as a test case.