fix(webhooks): endpoint requests modal label by miguelpeixe · Pull Request #2332 · Automattic/newspack-plugin

miguelpeixe · 2023-03-08T13:07:22Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Fixes the label of the endpoint name while viewing its requests modal.

How to test the changes in this Pull Request:

Make sure you have define( 'NEWSPACK_EXPERIMENTAL_WEBHOOKS', true );
While in the master branch, visit the Newspack -> Connections page and set up an endpoint with a Label if you haven't already
Click on the 3 dots menu and click "View requests"
Confirm the [object Object] in the text
Check out this branch and confirm the text has a proper label for the endpoint
Edit the endpoint, leave Label blank and save
View the requests and confirm the label is replaced with the shortened URL

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

# [1.108.0-alpha.1](v1.107.1...v1.108.0-alpha.1) (2023-03-16) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))

matticbot · 2023-03-16T18:51:38Z

🎉 This PR is included in version 1.108.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.109.0-alpha.1](v1.108.0...v1.109.0-alpha.1) (2023-03-20) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))

matticbot · 2023-03-20T10:17:01Z

🎉 This PR is included in version 1.109.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.110.0-alpha.1](v1.109.0...v1.110.0-alpha.1) (2023-03-24) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * **perfmatters:** add twitter.com to JS delay list ([34bac52](34bac52)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popup events to GA4 ([#2337](#2337)) ([62c738e](62c738e)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))

matticbot · 2023-03-24T15:02:15Z

🎉 This PR is included in version 1.110.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.110.0](v1.109.0...v1.110.0) (2023-03-27) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * **perfmatters:** add twitter.com to JS delay list ([34bac52](34bac52)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popup events to GA4 ([#2337](#2337)) ([62c738e](62c738e)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))

matticbot · 2023-03-27T19:18:59Z

🎉 This PR is included in version 1.110.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix(webhooks): endpoint requests modal label

009f2f8

miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 8, 2023

miguelpeixe requested a review from a team as a code owner March 8, 2023 13:07

miguelpeixe self-assigned this Mar 8, 2023

adekbadek approved these changes Mar 9, 2023

View reviewed changes

github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 9, 2023

miguelpeixe merged commit fd99ff2 into master Mar 9, 2023

miguelpeixe deleted the fix/webhooks-endpoint-requests-label branch March 9, 2023 12:37

matticbot added the released on @alpha label Mar 16, 2023

matticbot added the released label Mar 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(webhooks): endpoint requests modal label#2332

fix(webhooks): endpoint requests modal label#2332
miguelpeixe merged 1 commit intomasterfrom
fix/webhooks-endpoint-requests-label

miguelpeixe commented Mar 8, 2023

Uh oh!

matticbot commented Mar 16, 2023

Uh oh!

matticbot commented Mar 20, 2023

Uh oh!

matticbot commented Mar 24, 2023

Uh oh!

matticbot commented Mar 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

miguelpeixe commented Mar 8, 2023

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

matticbot commented Mar 16, 2023

Uh oh!

matticbot commented Mar 20, 2023

Uh oh!

matticbot commented Mar 24, 2023

Uh oh!

matticbot commented Mar 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants