feat(perfmatters): add back ads JS to script delay list#2354
Merged
feat(perfmatters): add back ads JS to script delay list#2354
Conversation
adekbadek
added
the
[Status] Needs Review
miguelpeixe
approved these changes
Mar 17, 2023
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Mar 20, 2023
# [1.108.0](v1.107.1...v1.108.0) (2023-03-20) ### Features * **perfmatters:** add ads, recaptcha JS to script delay list ([#2354](#2354)) ([e8d1703](e8d1703))
Contributor
|
🎉 This PR is included in version 1.108.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Ads-related JS was initially set to be delayed by Perfmatters, but this was changed in #2312 after finding out that it breaks ads on one live site. This was too heavy-handed though, and most sites would benefit from this performance enhancements without the ads broken. This particular site has a very complex ad stack, and Perfmatters settings should be adjusted individually in such cases.
How to test the changes in this Pull Request:
Other information: