Add Javascript files to PHPCS scan#5
Merged
Conversation
To make full use of the VIP Go standard we should include JS, as there are some handy rules in the Go standard that check for potential XSS vulnerabilties.
claudiulodro
requested changes
Mar 6, 2019
Contributor
claudiulodro
left a comment
claudiulodro
left a comment
There was a problem hiding this comment.
When I add a random JS file and try committing I get the following error when running the precommit hooks:
Installing JSHint
Failed to install jshint (try installing as a local package via 'npm install --save-dev jshint'), so skipping jshint
Does the JS linting work in your testing? It seems like we need a package.json.
claudiulodro
added
[Status] Needs Changes or Feedback
Contributor
|
I've pushed an update to exclude the |
claudiulodro
removed
the
[Status] Needs Changes or Feedback
claudiulodro
approved these changes
May 6, 2019
claudiulodro
added
the
[Status] Approved
6 tasks
3 tasks
kmwilkerson
added a commit
that referenced
this pull request
May 15, 2026
- Add isEligible guard on Reset: excluded for woocommerce-source emails and emails without a registry_slug (finding #1) - Capture previous status before optimistic update so rollback doesn't assume binary publish/draft (finding #2) - Drop view_category from enrichment response — dead data not consumed by the frontend (finding #3) - Add @todo NPPD-1532 comment on reset endpoint coupling (finding #4) - Add NPPD-1531 comment on optimistic update / store consolidation (#5) - Replace brittle PHPUnit count assertions with structural invariants: required keys, valid source/recipient, exclusive type keys, no duplicates, sort order (findings #6, #7, #8) - Add optimistic-rollback failure test and reset eligibility test (#9, #11) - Add 6th mockEmail fixture (WC draft) for cleaner activate test (#10) - Coerce pluginsReady with Boolean() to handle undefined (#12) - Use noticeText prop consistently on Notice (#13) - Fix preview placeholder to use neutral gray tokens (#14) - Trim EmailItem interface to consumed fields, add source (#15) - Add source-of-truth comment on category_order strings (#16) - Consolidate three duplicate TODO comments into one (#17) - Add NPPD-1525 ticket reference on EmailPreview TODO (#18) - Extract duplicated screen-reader h1 into PageHeading component (#19) - Add text-overflow ellipsis on trigger description column (#20) - Return localized string from recipient getValue for search (#21) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
To make full use of the VIP Go standard we should include JS, as there are some handy rules in the Go standard that check for potential XSS vulnerabilties.