Skip to content

Fix prop issues in select component#67

Merged
claudiulodro merged 1 commit into
masterfrom
fix/selectvalue
May 21, 2019
Merged

Fix prop issues in select component#67
claudiulodro merged 1 commit into
masterfrom
fix/selectvalue

Conversation

@claudiulodro
Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

Related #64

This PR fixes issues caused by destructuring assignment in the select component render. Props that are destructured need to be passed on to the base component, otherwise the base component won't have the information.

How to test the changes in this Pull Request:

  1. Before applying this patch, go to the components demo. Observe that the first select has 'First' as the selected variable, even though the code says 'Second'. Observe that the disabled select is not truly disabled:

Screen Shot 2019-05-21 at 10 08 33 AM

  1. Apply this patch. Go to the components demo. Observe that the first select has 'Second' and the disabled select is actually disabled:

Screen Shot 2019-05-21 at 10 10 10 AM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@claudiulodro claudiulodro added [Type] Bug Incorrect behavior or functionality [Status] Needs Review The issue or pull request needs to be reviewed labels May 21, 2019
@claudiulodro claudiulodro requested a review from iuravic May 21, 2019 17:17
@jeffersonrabb jeffersonrabb added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 21, 2019
@claudiulodro claudiulodro merged commit 65a1132 into master May 21, 2019
@claudiulodro claudiulodro deleted the fix/selectvalue branch May 21, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge [Type] Bug Incorrect behavior or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants