Skip to content

Style 'help' text for checkboxes#68

Merged
claudiulodro merged 1 commit into
masterfrom
fix/checkboxhelpstyle
May 22, 2019
Merged

Style 'help' text for checkboxes#68
claudiulodro merged 1 commit into
masterfrom
fix/checkboxhelpstyle

Conversation

@claudiulodro
Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

Related #64

This PR adds styling for the 'help' text on checkboxes.

Here is the design for this:
Screen Shot 2019-05-21 at 10 20 05 AM

Without the CSS in this PR, here is what it would look like:
Screen Shot 2019-05-21 at 10 25 30 AM

How to test the changes in this Pull Request:

  1. npm run clean; npm run build:webpack
  2. Go to Components Demo. Examine the new 'Checkbox w/Help' element I've added:

Screen Shot 2019-05-21 at 10 33 20 AM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@claudiulodro claudiulodro added [Type] Bug Incorrect behavior or functionality [Type] Enhancement Improved behavior or functionality [Status] Needs Review The issue or pull request needs to be reviewed labels May 21, 2019
@jeffersonrabb jeffersonrabb self-requested a review May 21, 2019 21:58
Copy link
Copy Markdown
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffersonrabb jeffersonrabb added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 21, 2019
@claudiulodro claudiulodro merged commit 08a8faa into master May 22, 2019
@claudiulodro claudiulodro deleted the fix/checkboxhelpstyle branch May 22, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge [Type] Bug Incorrect behavior or functionality [Type] Enhancement Improved behavior or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants