Skip to content

Style number/password/etc. inputs#70

Merged
claudiulodro merged 1 commit into
masterfrom
fix/numberstyles
May 22, 2019
Merged

Style number/password/etc. inputs#70
claudiulodro merged 1 commit into
masterfrom
fix/numberstyles

Conversation

@claudiulodro
Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

Related #64

The styles in the stylesheet were only getting applied to inputs with the 'text' type. I've removed the restriction, so all types of inputs (number, password, etc.) will get the styles.

Here is what the input looked like before the change:
Screen Shot 2019-05-21 at 2 12 14 PM

How to test the changes in this Pull Request:

  1. npm run clean; npm run build:webpack
  2. Go to Components Demo and observe number input there is styled:

Screen Shot 2019-05-21 at 2 18 01 PM

Other information:

  • [ x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@claudiulodro claudiulodro added [Type] Bug Incorrect behavior or functionality [Status] Needs Review The issue or pull request needs to be reviewed labels May 21, 2019
Copy link
Copy Markdown
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeffersonrabb jeffersonrabb added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 21, 2019
@claudiulodro claudiulodro merged commit 8fe2aaf into master May 22, 2019
@claudiulodro claudiulodro deleted the fix/numberstyles branch May 22, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge [Type] Bug Incorrect behavior or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants