Skip to content

feat(lint-js): use prettier in eslint; adjust prettier config#213

Merged
adekbadek merged 1 commit intotrunkfrom
feat/js-lint-with-prettier
Jun 4, 2025
Merged

feat(lint-js): use prettier in eslint; adjust prettier config#213
adekbadek merged 1 commit intotrunkfrom
feat/js-lint-with-prettier

Conversation

@adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Reestablishes using prettier in eslint config, and adjusts the prettier config to allow for longer line-width.

How to test the changes in this Pull Request:

  1. In a repository which uses newspack-scripts, either install newspack-scripts as a local package, or just replace the two files from this PR in node_modules/newspack-scripts/
  2. Run npm run lint:js and observe prettier rule errors
  3. Fixing these is a matter of PRs in the other repositories

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@naxoc naxoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took this for a test and it works and looks good 👍

@adekbadek adekbadek merged commit 3a38bf7 into trunk Jun 4, 2025
3 checks passed
@matticbot
Copy link

🎉 This PR is included in version 5.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants