Add invertSelf to the DOMMatrix object #1649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have no idea what Mocha/Node wants me to do here to make the tests pass. I've used the exact same code and style as used in the rest of the tests, and yet it complains about a syntax error, where there literally are no syntax errors. |
Pomax
commented
Aug 13, 2020
zbjornson
reviewed
Aug 14, 2020
Collaborator
zbjornson
left a comment
zbjornson
left a comment
There was a problem hiding this comment.
One other tiny suggestion while you're at it. Thanks for implementing this!
Contributor
Author
|
PR updated. |
Pomax
commented
Aug 14, 2020
Contributor
Author
|
@zbjornson? =) |
zbjornson
approved these changes
Aug 19, 2020
Collaborator
zbjornson
left a comment
zbjornson
left a comment
There was a problem hiding this comment.
Looks good! Math checks out. Thanks 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #1648 by adding the implementation for
invertSelf().inverse()andinvertSelf()addedsection of the Changelog