Skip to content

Fix segfault in putImageData #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2016
Merged

Fix segfault in putImageData #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/CanvasRenderingContext2d.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,8 @@ NAN_METHOD(Context2d::AddPage) {
*/

NAN_METHOD(Context2d::PutImageData) {
if (!info[0]->IsObject())
return Nan::ThrowTypeError("ImageData expected");
Local<Object> obj = info[0]->ToObject();
if (!Nan::New(ImageData::constructor)->HasInstance(obj))
return Nan::ThrowTypeError("ImageData expected");
Expand Down
38 changes: 38 additions & 0 deletions test/canvas.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,44 @@ describe('Canvas', function () {
assert.equal(255, imageData.data[i+3]);
});

it('Context2d#getImageData()', function () {
var canvas = new Canvas(1, 1)
, ctx = canvas.getContext('2d');

assert.throws(function () { ctx.getImageData(0, 0, 0, 0); }, /IndexSizeError/);

ctx.fillStyle = '#f00';
ctx.fillRect(0, 0, 1, 1);

var pixel = ctx.getImageData(0, 0, 1, 1);

assert.equal(pixel.data[0], 255);
assert.equal(pixel.data[1], 0);
assert.equal(pixel.data[2], 0);
assert.equal(pixel.data[3], 255);
});

it('Context2d#putImageData()', function () {
var canvas = new Canvas(2, 1)
, ctx = canvas.getContext('2d');

assert.throws(function () { ctx.putImageData({}, 0, 0); }, TypeError);
assert.throws(function () { ctx.putImageData(undefined, 0, 0); }, TypeError);

ctx.fillStyle = '#f00';
ctx.fillRect(0, 0, 1, 1);

// Copy left pixel to the right pixel
ctx.putImageData(ctx.getImageData(0, 0, 1, 1), 1, 0);

var pixel = ctx.getImageData(1, 0, 1, 1);

assert.equal(pixel.data[0], 255);
assert.equal(pixel.data[1], 0);
assert.equal(pixel.data[2], 0);
assert.equal(pixel.data[3], 255);
});

it('Canvas#createSyncPNGStream()', function (done) {
var canvas = new Canvas(20, 20);
var stream = canvas.createSyncPNGStream();
Expand Down