Add failing test: CSS concat service drops @import rules#97
Merged
Conversation
mreishus
force-pushed
the
reish20260203/show-service-drops-imports
branch
from
d7139d2 to
d38473c
Compare
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test that exposes a bug in the CSS concatenation service where
@importrules silently disappear from the output.What the test does:
@import/_static/??concat request against them@importdirective survives in the responseWhy it fails on trunk:
The concat service tries to hoist
@import(and@charset) to the top of combined output via a$pre_outputbuffer, but due to a closure scoping issue, those rules get stripped from the source and written to a different variable - so they vanish entirely.Changes:
service.php: Adds aPAGE_OPTIMIZE_SKIP_SERVICE_REQUESTguard so the test canrequirethe file without triggering the live service entry point.tests/test-css-service-imports.php: New test case covering this scenario.