Add GenericHttpDataSource#495
Merged
Merged
Conversation
Contributor
|
Test this PR in WordPress Playground. |
ingeniumed
approved these changes
May 2, 2025
Contributor
|
Closes VIPCMS-1226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
HttpDataSourcedirectly, we extend it to createGenericHttpDataSource. This allows us to specify (and validate) an opinionated service config that does not impose any constraints on consumers ofHttpDataSource.After discussion with @shekharnwagh, we agreed to pull
service_configout ofHttpDataSourceentirely since it is a private implementation detail for our integrations.