Improve jitter placement#544
Merged
Merged
Conversation
chriszarate
requested review from
acicovic and
maxschmeling
and removed request for
a team
Contributor
|
Test this PR in WordPress Playground. |
maxschmeling
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move TTL jitter code to
RdbCacheStrategyas a more authoritative placement. This also allows us to add jitter to error response caching.This PR also renames private methods in
Validatorso that they have distinct names. (TheTypesclass also has acheck_typemethod.) This makes New Relic stack traces easier to read.Both changes will help our performance testing re-run.