-
Notifications
You must be signed in to change notification settings - Fork 54
Studio CLI: Fix Windows E2E tests #2299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fredrikekelund
wants to merge
47
commits into
dev/studio-cli-i2
Choose a base branch
from
f26d/fix-e2e-tests-windows
base: dev/studio-cli-i2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+241
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help us diagnose which specific files or directories are causing trouble
This reverts commit 8786163.
fredrikekelund
commented
Dec 19, 2025
Comment on lines
+129
to
+130
|
|
||
| process.on( 'SIGINT', disconnect ); |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The studio site list --watch command would previously not interrupt in response to Ctrl+C
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
This PR fixes the Windows E2E tests by making the following changes:
site list --watchcommand in response toSIGINTandSIGTERMsignals. Without this, thesite list --watchcommand couldn't be aborted with Ctrl+C, but also, theelectronApp.close()call would hang because the site watcher child process would never quit.site stop-allcommand in a detached and unrefed process to ensure the Electron app can quit independently of it. This is relevant because we trigger this command when the app quits, and it takes a few seconds to complete. We could look into improving the performance of this command, but regardless, this implementation is the way to go because it guarantees correct behavior.E2ESession::cleanup. This method was giving us a lot of grief, especially on Windows, because some processes kept holding file locks, preventing the directory from being removed. After trying several retry strategies to remove the directories, I settled on simply leaving them in place. See code comment for more details about why I think this is a viable strategy.e2e/blueprints.test.ts. We are investigating site creation performance on thedev/studio-cli-i2branch, so hopefully this isn't needed long-term (it might not even be needed on CI), but I had to do it to get the tests to pass on my Windows VM.themeZipFileandpluginZipFilebeing deprecated, so I also took the opportunity to replace those keys withthemeDataandpluginDatain the test fixtures.site list --watch) and wait for thespawnevent from the child process before creating the main app window.Testing Instructions
CI should pass.
Pre-merge Checklist