Sync: Increase push size to 5 GB

[epeicher]

Related issues

• Fixes STU-940

Proposed Changes

• Increase push limit size from 2 GB to 5 GB

Testing Instructions

• Checkout this branch and run npm start
• Add large media files to an existing Studio site (tip: you can use this tool to generate large images)
• Navigate to the Sync tab and connect the large Studio site to a WP.com site
• Click on Push and select all files
• Verify the reported limit is 5 GB instead of 2 GB and that you can Push the large Studio site

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[wpmobilebot]

📊 Performance Test Results

Comparing 915332c vs trunk

site-editor

Metric	trunk	915332c	Diff	Change
load	8005.00 ms	6893.00 ms	-1112.00 ms	🟢 -13.9%

site-startup

Metric	trunk	915332c	Diff	Change
siteCreation	9078.00 ms	9095.00 ms	+17.00 ms	🔴 0.2%
siteStartup	3937.00 ms	3952.00 ms	+15.00 ms	🔴 0.4%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[gavande1]

Thanks for working on this @epeicher. I am not sure if this already planned but adding here anyways. This will probably need related backend changes. You can find the where define the constant fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Szh%2Qcyhtvaf%2Sfvgr%2Qfghqvb%2Spynff.fvgr%2Qfghqvb%2Qvzcbeg%2Qznantre.cuc%3Se%3Q976954o6%2353-og

[katinthehatsite]

This looks good to me, aside from needing to make the additional backend changes:

The e2e failure seem to be unrelated 👍

[epeicher]

Thanks for working on this @epeicher. I am not sure if this already planned but adding here anyways. This will probably need related backend changes. You can find the where define the constant uggcf%3N%2S%2Suers.yv%2S%3Suggcf%3N%2S%2Sbcratebx.n8p.pbz%2Sfbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Szh%2Qcyhtvaf%2Sfvgr%2Qfghqvb%2Spynff.fvgr%2Qfghqvb%2Qvzcbeg%2Qznantre.cuc%3Se%3Q976954o6%2353-og

Thanks @gavande1 for the suggestion! I have been having a look and doing some testing, and I think the Studio limit and backend limit are different because the backend limit is being compared against a compressed archive. So a Studio site that has around 5 GB is reduced to much less than 2 GB, in my testing a site has been compressed to ~ 40 MB.

EDIT: I have tested adding JPEG images that don't compress that much and there could be some scenarios where the compressed archive has a similar size than the Studio site so I am going to update that constant too. Thanks for noting it @gavande1!

[katinthehatsite]

Thanks @gavande1 for the suggestion! I have been having a look and doing some testing, and I think the Studio limit and backend limit are different because the backend limit is being compared against a compressed archive. So a Studio site that has around 5 GB is reduced to much less than 2 GB, in my testing a site has been compressed to ~ 40 MB.

I just wanted to mention (since I was following this thread) is that I would change it to 5GB in any case to make sure that we are consistent everywhere. It would be quite frustrating for someone who looks the code up for the first time to see two different numbers and not see the clear reason what are those and where the difference is coming from.

[epeicher]

Thanks @gavande1 for the suggestion! I have been having a look and doing some testing, and I think the Studio limit and backend limit are different because the backend limit is being compared against a compressed archive. So a Studio site that has around 5 GB is reduced to much less than 2 GB, in my testing a site has been compressed to ~ 40 MB.

I just wanted to mention (since I was following this thread) is that I would change it to 5GB in any case to make sure that we are consistent everywhere. It would be quite frustrating for someone who looks the code up for the first time to see two different numbers and not see the clear reason what are those and where the difference is coming from.

@gavande1, @katinthehatsite I have created 199686-ghe-Automattic/wpcom for that

[gcsecsey]

The client side changes look good to me, I can see the updated limit and can start pushing a site larger than the earlier 2GB limit. I'll also test this together with 199686-ghe-Automattic/wpcom on the backend.

[gcsecsey]

I tested this change together with 199686-ghe-Automattic/wpcom and I could successfully start uploading a site that's over the 2GB limit.

[gavande1]

Thanks @gcsecsey for testing. My internet connection seems to be very slow at this moment, and I couldn't complete the upload test. But Gergely's test confirms it works well. The code wise it looks good to me. 👍