Studio: Add site does not duplicate sites

[katinthehatsite]

Related issues

Fixes STU-1210

Proposed Changes

This PR ensures that when you add a site from Add site in the sidebar, only one site gets added and there is no duplication.

Testing Instructions

• Pull the changes from this branch
• Start Studio with npm start
• In the sidebar, click on Add site
• Observe that once the site is added, it only gets added once and you don't see any duplicate sites

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[bcotrim]

Thanks @katinthehatsite for looking into this issue.
We already do a similar check in the main process before emitting the site-event event to the UI.
Have you confirmed what is the issue with that check? It would be preferable to keep the logic in the main process and leave the UI as simple as possible, in my opinion.

[wpmobilebot]

📊 Performance Test Results

Comparing bc0c681 vs trunk

site-editor

Metric	trunk	bc0c681	Diff	Change
load	2942.00 ms	2895.00 ms	-47.00 ms	🟢 -1.6%

site-startup

Metric	trunk	bc0c681	Diff	Change
siteCreation	7089.00 ms	7076.00 ms	-13.00 ms	🟢 -0.2%
siteStartup	3945.00 ms	3946.00 ms	+1.00 ms	🔴 0.0%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[bcotrim]

Thanks @katinthehatsite for looking into this issue. We already do a similar check in the main process before emitting the site-event event to the UI. Have you confirmed what is the issue with that check? It would be preferable to keep the logic in the main process and leave the UI as simple as possible, in my opinion.

I forgot to add the link to the existing check:
https://github.com/Automattic/studio/blob/trunk/src/modules/cli/lib/cli-events-subscriber.ts#L42

[katinthehatsite]

We already do a similar check in the main process before emitting the site-event event to the UI.
Have you confirmed what is the issue with that check? It would be preferable to keep the logic in the main process and leave the UI as simple as possible, in my opinion.

I see, thanks for adding the link @bcotrim . I looked into the check and it seems that it exited the main process correctly but did not notify the renderer process about the exit properly. I made some changes to src/modules/cli/lib/cli-events-subscriber.ts - let me know what you think!

[bcotrim]

Thanks for finding and fixing the issue @katinthehatsite

Nit: If we move sendIpcEventToRenderer inside the handleSiteEvent function, we could structure it with early returns for the "don't send" cases and a single send at the end. In my opinion, it makes the function intention easier to read and understand.

[katinthehatsite]

Nit: If we move sendIpcEventToRenderer inside the handleSiteEvent function, we could structure it with early returns for the "don't send" cases and a single send at the end. In my opinion, it makes the function intention easier to read and understand.

Thanks for the suggestion! I did the refactor in bc0c681