Fix Blueprint version warning not displaying immediately#2430
Merged
Fix Blueprint version warning not displaying immediately#2430
Conversation
The warning now compares Blueprint versions against original defaults instead of current form values, ensuring it shows right away when a Blueprint with different versions is selected.
Displays "1 warning found" in amber when a Blueprint specifies version requirements different from defaults, matching the existing error indicator behavior.
Prevents the PHP dropdown from showing an incorrect value when a Blueprint specifies an unsupported PHP version (e.g., 7.0). Now only applies the Blueprint version if it's in the SupportedPHPVersionsList.
gavande1
approved these changes
Jan 21, 2026
wojtekn
reviewed
Jan 21, 2026
Contributor
wojtekn
left a comment
wojtekn
left a comment
There was a problem hiding this comment.
It works correctly now - I see the warning icon right away, even without expanding the Advanced settings.
wojtekn
approved these changes
Jan 21, 2026
Collaborator
📊 Performance Test ResultsComparing 8169a9a vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
wojtekn
deleted the
STU-1218/blueprint-version-warning-immediate-display
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Issue
When creating a site from a Blueprint with specific PHP/WP version requirements, the version mismatch warning only appeared after manually changing the version dropdowns - not immediately when the Blueprint was selected.
Proposed Changes
1 warning foundwhen PHP or WordPress versions are not supported.Testing Instructions
npm startand click "Add site"php-wp-version-warning.mp4
Pre-merge Checklist