Fix thumbnail not loading for newly created sites #2484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Related issues
Proposed Changes
When a new site is created, there was a race condition in the IPC event sequencing:
theme-details-loadedarrives and setsloadingThemeDetails = falsethumbnail-loadinghasn't arrived yet, soloadingThumbnailsis stillundefinedsrconError, setting the error state permanentlythumbnail-loadedfinally arrives, the error state is already set and "Preview unavailable" is shownThe fix ensures proper sequencing by:
thumbnail-loadingearly (at the same time astheme-details-loading) when creating a new sitethumbnail-loadedorthumbnail-load-errorto complete the loading statethumbnail-loadingbefore updating the thumbnail so the skeleton showsTesting Instructions
New site creation
Theme changes
Error handling
Pre-merge Checklist