Fix About window path #2496
Fix About window path #2496
Conversation
📊 Performance Test ResultsComparing 05fc06b vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
epeicher
left a comment
epeicher
left a comment
There was a problem hiding this comment.
Thanks @ivan-ottinger! This works as expected, I can see the correct about window in both development and production builds. LGTM! 
Development version running npm start |
Production version running npm run make |
|---|---|
 |
 |
sejas
left a comment
sejas
left a comment
There was a problem hiding this comment.
Great fix Ivan! I tested it in dev npm start, and build npm run make versions, and I confirm the about page appears in both modes for each platform, Mac and Windows. I also tested v1.7.2 in Windows parallels.
| Mac | Windows |
|---|---|
 |
 |
| ? path.join( getResourcesPath(), 'src', 'about-menu', 'about-menu.html' ) | ||
| : path.join( getResourcesPath(), 'dist', 'renderer', 'about-menu.html' ); | ||
| if ( process.env.NODE_ENV === 'development' ) { | ||
| return path.join( __dirname, '../../src/about-menu/about-menu.html' ); |
There was a problem hiding this comment.
Interesting that the paths work even with the hard-coded slashes (/).
There was a problem hiding this comment.
Yes, that's right. I expected it would not work correctly.
Related issues
Proposed Changes
Testing Instructions
Run
npm startOpen Studio → About WordPress Studio
Verify the About window displays correctly with the icon, version, and links
Run
npm run makethen launch the packaged appOpen Studio → About WordPress Studio
Verify the About window displays correctly
The change should work on both macOS and Windows.
Pre-merge Checklist