Skip to content

CLI: fix --skip-site-details argument for starting site which is already running#2510

Merged
nightnei merged 1 commit intotrunkfrom
fixSkipSiteDetailsForStartingSite
Feb 2, 2026
Merged

CLI: fix --skip-site-details argument for starting site which is already running#2510
nightnei merged 1 commit intotrunkfrom
fixSkipSiteDetailsForStartingSite

Conversation

@nightnei
Copy link
Contributor

Related issues

Proposed Changes

If a site is already running and we execute node dist/cli/main.js site start --skip-log-details - the --skip-log-details argument is ignored.

Testing Instructions

  1. Run node dist/cli/main.js site start --path=<PATH> --skip-log-details
  2. Assert taht you don't see
    Screenshot 2026-01-31 at 16 33 25
  3. Run again node dist/cli/main.js site start --path=<PATH> --skip-log-details
  4. Assert taht you don't see (before if was anyway printed)
    Screenshot 2026-01-31 at 16 33 25

@nightnei nightnei requested a review from a team January 31, 2026 16:34
@nightnei nightnei self-assigned this Jan 31, 2026
@wpmobilebot
Copy link
Collaborator

📊 Performance Test Results

Comparing 5146c07 vs trunk

site-editor

Metric trunk 5146c07 Diff Change
load 2840.00 ms 2835.00 ms -5.00 ms 🟢 -0.2%

site-startup

Metric trunk 5146c07 Diff Change
siteCreation 7078.00 ms 7086.00 ms +8.00 ms 🔴 0.1%
siteStartup 3927.00 ms 3927.00 ms 0.00 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected and I don't see the login credentials when using the --skip-log-details parameter.

Before After
Screenshot 2026-02-02 at 10 50 54 Screenshot 2026-02-02 at 10 51 06

@nightnei nightnei merged commit e4bc222 into trunk Feb 2, 2026
9 checks passed
@nightnei nightnei deleted the fixSkipSiteDetailsForStartingSite branch February 2, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants