Upgrade node to v24 only for CLI by katinthehatsite · Pull Request #2537 · Automattic/studio

katinthehatsite · 2026-02-05T10:10:34Z

Related issues

Proposed Changes

This PR ensures that we upgrade node version only for CLI and not for the whole Studio project. Electron is currently using v39.x and is not compatible with Node v24. I explored upgrading Electron so that CLI and the rest of the Studio project could use the same configuration but ran into a blocker with fs-ext. Additionally, according to this comment: #2486 (comment) , it seems that our goal is to untangle with node versions used by CLI and Studio anyway.

Testing Instructions

Confirm that in CI, we get the node 22.x installed:

To test CLI node version:

Pull the changes from this branch
Run nvm use && npm install
Run npm run cli:build
Run ./bin/node --version
Confirm you see node v24.11.0
For good measure, confirm that ./bin/node dist/cli/main.js --help works as expected

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors?

katinthehatsite · 2026-02-05T10:11:18Z

+	archivePath: string,
+	destDir: string,
+	binaryName: string
+): Promise< void > {


These are unrelated linter fixes

katinthehatsite · 2026-02-05T10:11:27Z

 }

-main();
+void main();


Unrelated linter fix

katinthehatsite · 2026-02-05T10:14:05Z

@@ -1 +1 @@
-24.11.0
+22.20.0


These are the changes reverted back from #2486

katinthehatsite · 2026-02-05T10:26:05Z

@@ -0,0 +1 @@
+24.11.0


This file could be called something else if this is not clear. I also thought about hard-coding it directly into download-node-binary but it could be slightly harder to find that way

If it's used only in one place and is not an industry-standard file like .nvmrc, we could hardcode it there. There is no value in creating a new file format for that.

We follow the same approach with the SQLite plugin version.

Sounds good to me, made changes in d9021ad

I also removed the fallback as it should not be needed as the version is always defined.

wpmobilebot · 2026-02-05T11:11:09Z

📊 Performance Test Results

Comparing c4b16e6 vs trunk

site-editor

Metric	trunk	`c4b16e6`	Diff	Change
load	2768.00 ms	2757.00 ms	-11.00 ms	🟢 -0.4%

site-startup

Metric	trunk	`c4b16e6`	Diff	Change
siteCreation	7079.00 ms	7081.00 ms	+2.00 ms	🔴 0.0%
siteStartup	3933.00 ms	3930.00 ms	-3.00 ms	🟢 -0.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Co-authored-by: Wojtek Naruniec <wojtek.naruniec@automattic.com>

ivan-ottinger

Thanks for the changes, Kat.

ivan-ottinger · 2026-02-05T14:35:49Z

+// This is separate from .nvmrc which controls the development environment and Electron app
+const BUNDLED_NODE_VERSION = 'v24.11.0';

 function getNodeVersion(): string {


I think we could now get rid of the wrapper getNodeVersion now - since it returns one constant only.

Thanks, should be updated 👍

Thanks for the update, Kat! Looks good! 👍🏼

…dio into fix/update-npm-in-engines

fredrikekelund · 2026-02-10T09:18:34Z

Connecting the dots between #2486 (comment) and this change…

.nvmrc dictates which node version we use for development, primarily for Studio CLI and potentially (though unlikely, IMO) also for the Electron "back-end logic". It doesn't dictate which node version Electron uses for the "back-end logic" after the app is packaged.

We should not use a different node version for Studio CLI development compared to what we ship in the installer, since we won't be able to catch potential issues related to the node version.

@wojtekn, I'll experiment with the approach we took in #2486 and try to reproduce the error you described in #2486 (comment)

Kateryna Kodonenko added 2 commits February 5, 2026 10:32

Fix npm warnings

5e2adc0

Upgrade node only for CLI

9683b19

katinthehatsite self-assigned this Feb 5, 2026

katinthehatsite marked this pull request as draft February 5, 2026 10:10

katinthehatsite commented Feb 5, 2026

View reviewed changes

Comment thread scripts/download-node-binary.ts

}

main();

void main();

Copy link
Copy Markdown

Contributor Author

katinthehatsite Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated linter fix

Remove unintended changes

e38f20f

katinthehatsite commented Feb 5, 2026

View reviewed changes

Comment thread .nvmrc

@@ -1 +1 @@

24.11.0

22.20.0

Copy link
Copy Markdown

Contributor Author

katinthehatsite Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes reverted back from #2486

katinthehatsite marked this pull request as ready for review February 5, 2026 10:24

katinthehatsite requested review from a team, ivan-ottinger and wojtekn February 5, 2026 10:24

katinthehatsite mentioned this pull request Feb 5, 2026

Update .nvmrc to use Node.js v24 #2486

Merged

1 task

katinthehatsite commented Feb 5, 2026

View reviewed changes

Use hardcoded version

d9021ad

wojtekn approved these changes Feb 5, 2026

View reviewed changes

Comment thread scripts/download-node-binary.ts

Update scripts/download-node-binary.ts

f3c5570

Co-authored-by: Wojtek Naruniec <wojtek.naruniec@automattic.com>

ivan-ottinger reviewed Feb 5, 2026

View reviewed changes

Kateryna Kodonenko added 2 commits February 6, 2026 09:42

Remove node version wrapper

2ca8ad2

Merge branch 'fix/update-npm-in-engines' of github.com:Automattic/stu…

c4b16e6

…dio into fix/update-npm-in-engines

ivan-ottinger self-requested a review February 6, 2026 08:50

ivan-ottinger approved these changes Feb 6, 2026

View reviewed changes

katinthehatsite merged commit 9c147d4 into trunk Feb 6, 2026
11 checks passed

katinthehatsite deleted the fix/update-npm-in-engines branch February 6, 2026 09:16

fredrikekelund mentioned this pull request Feb 16, 2026

Upgrade .nvmrc to Node 24 and fix deprecation warnings #2594

Merged

1 task

Conversation

katinthehatsite commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues

Proposed Changes

Testing Instructions

Pre-merge Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Performance Test Results

site-editor

site-startup

Uh oh!

Uh oh!

ivan-ottinger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fredrikekelund commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

katinthehatsite commented Feb 5, 2026 •

edited

Loading

wpmobilebot commented Feb 5, 2026 •

edited

Loading