Conversation
📊 Performance Test ResultsComparing e38caf7 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
| <div className="flex flex-row px-5 pb-1 justify-between align-center self-stretch opacity-70"> | ||
| <p className="text-xxs leading-4"> | ||
| { sprintf( | ||
| _n( '%d site running', '%d sites running', runningSites.length ), |
There was a problem hiding this comment.
Makes sense, I changed it in e38caf7 so we will keep the current behavior. I will keep the opposite case as is, as it is a nice indicator of the number of all sites.
sejas
left a comment
There was a problem hiding this comment.
I confirm I'm able to start all the sites. The button is visible only if all the sites are stopped.
Code looks good. It iterates for each site and call startServer for each.
https://github.com/user-attachments/assets/64ac3441-0453-493c-9c91-4f5a3074081e
bcotrim
left a comment
There was a problem hiding this comment.
LGTM 👍
I wonder if we could add a studio site start --all similar to the existing studio site stop --all command, to keep CLI parity.
This discussion could be a follow up PR, if we decide to implement it, since the current change works perfectly already




Related issues
Proposed Changes
I propose to add an ability to start all stopped sites. I kept "Start all" only for case in which no sites are running, and "Stop all" for all other cases to keep UI simple.
Testing Instructions