Add site name to start site dialog error

[sejas]

Related issues

• Fixes STU-1287

Proposed Changes

• Adds the site name to error dialog title to all 5 errors when a site fails to start, helping users identify which site failed (especially useful during "Start all" or autostart sites on launch)
• Optimizes auto start sites to run it only on mounting the provider.
• Adds comprehensive unit tests for all error branches, with a shared setupStartServerError helper to reduce boilerplate
• Changes startSite parameter to receive the whole site to make easier to get the site name.

Testing Instructions

Automated

• npm test -- src/hooks/tests/use-site-details.test.tsx

Manual

• Create a site
• Add some code to make it fail at start, for example add these constants to wp-config.php

define( 'WP_ALLOW_MULTISITE', true );
define( 'MULTISITE', true );

• Start that specific site or start all the sites
• Observe that the alert appears, and confirm the site name is included in the title.

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[wpmobilebot]

📊 Performance Test Results

Comparing 3f34c0e vs trunk

site-editor

Metric	trunk	3f34c0e	Diff	Change
load	2694.00 ms	2694.00 ms	0.00 ms	⚪ 0.0%

site-startup

Metric	trunk	3f34c0e	Diff	Change
siteCreation	6074.00 ms	6098.00 ms	+24.00 ms	⚪ 0.0%
siteStartup	3930.00 ms	3926.00 ms	-4.00 ms	⚪ 0.0%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

[nightnei]

Works well and LGTM, only one tiny thing - take a look please at the comment. Anyway approved, as it's not very critical 👍

[nightnei]

Why do we need this trick with useRef?
Theotretically it should work well if we include sites into useCallback dependencies of startServer function, unless I am missing something.

[sejas]

Fixed on ad7d197
And then optimized array dependencies on 3f34c0e

[nightnei]

@sejas I see the changes, so you can ignore my previous comment, reviewing again 🙂

[sejas]

@nightnei , great feedback! Consider last changes addressing your suggestion :D.
The useRef was used to avoid an infinite loop producedby the auto start logic. In my last changes I've optimized the auto start useEffect to run only on mount, and I also optimized the startSite logic to grab the site name from the parameter. 👍

[nightnei]

@sejas It's unreally awesome commit - having full site will definitely be usefull and simplify the codebase in future changes, the same as in this case 🔥
Looks great and works as expected 👍