Patch fs-ext-extra-prebuilt to remove other-platform binaries on install by wojtekn · Pull Request #2615 · Automattic/studio

wojtekn · 2026-02-19T14:16:40Z

Related issues

N/A - trying to fix builds broken after recent Playground update.

Proposed Changes

Applies upstream fix (adamziel/fs-ext-prebuilt#6) via custom script
The script deletes .node binaries for other platforms during postinstall and bundle steps
Fixes Performance Metrics broken after monorepo merge
Fixes builds, mainly around out/ paths

Testing Instructions

Run npm install and verify no errors
On Windows: verify code signing doesn't fail on Linux/macOS .node files from fs-ext-extra-prebuilt

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors?

Applies upstream fix (adamziel/fs-ext-prebuilt#6) via patch-package to remove binaries for other platforms after a successful prebuilt load. This prevents Windows code-signing tools from encountering Linux/macOS .node files they cannot process.

wojtekn · 2026-02-19T14:19:01Z

 		"start": "npm -w studio-app run start",
 		"start-wayland": "npm -w studio-app run start-wayland",
-		"postinstall": "patch-package --patch-dir apps/cli/patches && patch-package --patch-dir apps/studio/patches && ts-node ./scripts/download-wp-server-files.ts && node ./scripts/download-available-site-translations.mjs",
+		"postinstall": "patch-package && patch-package --patch-dir apps/cli/patches && patch-package --patch-dir apps/studio/patches && ts-node ./scripts/download-wp-server-files.ts && node ./scripts/download-available-site-translations.mjs",


@fredrikekelund this packages is dependency for @studio/common, benchmark-site-editor and studio-cli. With the monorepo setup, is applying that in the prokject root's node_modules/ a way to go?

Good question. This is probably one of the biggest gotchas with our monorepo setup now.

As part of the packaging flow, we now run the install:bundle npm scripts in apps/cli and apps/studio. They do this:

npm install [--omit=dev] --no-package-lock --no-progress --install-links --no-workspaces

The goal is to produce self-contained apps/cli/node_modules and apps/studio/node_modules directories, because those are copied into the packaged output.

This goal conflicts with how dependency management typically works with our npm workspaces setup, which is that most (not all) dependencies are hoisted to the root node_modules directory.

So, how does this affect patches? Well, patch-package fails if it finds a patch without a matching dependency. That's why we have separate apps/cli/patches and apps/studio/patches directories, because otherwise the install:bundle npm scripts would fail.

To answer your question directly: just put the patch in apps/cli/patches. fs-ext-extra-prebuilt is a dev dependency of @studio/common, so it won't be included in the self-contained packaged node_modules directories.

Thanks for the clarification. I moved it, and it works fine.

fredrikekelund

LGTM 👍 I've triggered a Windows dev build on Buildkite. Let's see how that fares before we land this

wpmobilebot · 2026-02-19T15:57:22Z

📊 Performance Test Results

Comparing cef34dc vs trunk

site-editor

Metric	trunk	`cef34dc`	Diff	Change
load	1481.00 ms	1491.00 ms	+10.00 ms	⚪ 0.0%

site-startup

Metric	trunk	`cef34dc`	Diff	Change
siteCreation	7117.00 ms	8104.00 ms	+987.00 ms	🔴 13.9%
siteStartup	4944.00 ms	4947.00 ms	+3.00 ms	⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

…cript The patch-package approach patched install.js but that script had already run before patch-package executes, so no binaries were actually removed. Instead, run a dedicated script from postinstall that deletes non-current- platform binaries from fs-ext-extra-prebuilt/binaries directly, preventing Windows code-signing from encountering darwin/linux .node files.

wojtekn · 2026-02-19T17:22:05Z

 		"start": "npm -w studio-app run start",
 		"start-wayland": "npm -w studio-app run start-wayland",
-		"postinstall": "patch-package --patch-dir apps/cli/patches && patch-package --patch-dir apps/studio/patches && ts-node ./scripts/download-wp-server-files.ts && node ./scripts/download-available-site-translations.mjs",
+		"postinstall": "patch-package --patch-dir apps/cli/patches && patch-package --patch-dir apps/studio/patches && node ./scripts/remove-fs-ext-other-platform-binaries.mjs && ts-node ./scripts/download-wp-server-files.ts && node ./scripts/download-available-site-translations.mjs",


It didn't work with the patch, as the patch was applied after the package was installed. I moved the logic to custom scripts as a hotfix.

We can remove those when the library is fixed.

wojtekn · 2026-02-19T19:32:57Z


 # Rename NuGet package files with generic name
-$artifactsPath = Get-Item ".\out" | Select-Object -ExpandProperty FullName
+$artifactsPath = Get-Item ".\apps\studio\out" | Select-Object -ExpandProperty FullName


We missed that during the monorepo change.

wojtekn · 2026-02-20T07:34:13Z

+          - apps\studio\out\**\studio-setup.exe
+          - apps\studio\out\**\studio-update.nupkg
+          - apps\studio\out\**\RELEASES
+          - apps\studio\out\**\*.appx


Those are the remaining changes that follow the monorepo change.

wojtekn commented Feb 19, 2026

View reviewed changes

wojtekn self-assigned this Feb 19, 2026

wojtekn requested a review from a team February 19, 2026 14:19

wojtekn added 2 commits February 19, 2026 15:36

Move patch to apps/cli/patches, revert package.json change

cb72d24

Clean up lock changes

9f743b1

fredrikekelund approved these changes Feb 19, 2026

View reviewed changes

fredrikekelund added 3 commits February 19, 2026 15:57

Fix performance test

5a7be23

Fix paths in compare-perf job

d9be214

One more fix

9decf1e

wojtekn mentioned this pull request Feb 19, 2026

Fix Performance Metrics broken import #2617

Closed

1 task

wojtekn commented Feb 19, 2026

View reviewed changes

wojtekn added 3 commits February 19, 2026 19:16

Fix fs-ext cleanup to run after install:bundle, not just postinstall

49e5f22

Run fs-ext cleanup after CLI install:bundle too

fcd4083

Fix Windows build script to look for artifacts in apps/studio/out

5f80ac9

wojtekn commented Feb 19, 2026

View reviewed changes

Fix Windows artifact paths to apps/studio/out in pipeline

cef34dc

wojtekn commented Feb 20, 2026

View reviewed changes

wojtekn merged commit 44012f2 into trunk Feb 20, 2026
12 checks passed

wojtekn deleted the fix-fs-ext-extra-prebuilt-cross-platform-binaries branch February 20, 2026 07:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patch fs-ext-extra-prebuilt to remove other-platform binaries on install#2615

Patch fs-ext-extra-prebuilt to remove other-platform binaries on install#2615
wojtekn merged 11 commits into
trunkfrom
fix-fs-ext-extra-prebuilt-cross-platform-binaries

wojtekn commented Feb 19, 2026 •

edited

Loading

Uh oh!

wojtekn Feb 19, 2026

Uh oh!

fredrikekelund Feb 19, 2026

Uh oh!

wojtekn Feb 19, 2026

Uh oh!

fredrikekelund left a comment

Uh oh!

wpmobilebot commented Feb 19, 2026 •

edited

Loading

Uh oh!

wojtekn Feb 19, 2026 •

edited

Loading

Uh oh!

wojtekn Feb 19, 2026

Uh oh!

wojtekn Feb 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

wojtekn commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues

Proposed Changes

Testing Instructions

Pre-merge Checklist

Uh oh!

wojtekn Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

fredrikekelund Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

wojtekn Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

fredrikekelund left a comment

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Performance Test Results

site-editor

site-startup

Uh oh!

wojtekn Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wojtekn Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

wojtekn Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wojtekn commented Feb 19, 2026 •

edited

Loading

wpmobilebot commented Feb 19, 2026 •

edited

Loading

wojtekn Feb 19, 2026 •

edited

Loading