Conversation
Restore the custom macOS traffic light position after calling setWindowButtonVisibility(true), which does not preserve the position set during BrowserWindow creation. Extract the position into a shared MACOS_TRAFFIC_LIGHT_POSITION constant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bcotrim
approved these changes
Feb 20, 2026
Contributor
bcotrim
left a comment
There was a problem hiding this comment.
Works as described
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related issues
Proposed Changes
Long explanation:
{ x: 20, y: 20 }) into a sharedMACOS_TRAFFIC_LIGHT_POSITIONconstant inconstants.tsmain-window.tsinstead of the hardcoded literalsetWindowButtonVisibility(true)in thesetWindowControlVisibilityIPC handler, restore the custom position viasetWindowButtonPosition(MACOS_TRAFFIC_LIGHT_POSITION)— this fixes the alignment shift caused by Electron not preserving the customtrafficLightPositionwhen re-showing window buttonsTesting Instructions
npm starton MacOScmd+nescBefore
window-buttons-mac-before.mp4
After
window-buttons-mac-after.mp4
Pre-merge Checklist