Skip to content

Studio: Re-selecting the same file doesn't trigger the import#2768

Merged
epeicher merged 1 commit intotrunkfrom
fix/import-same-file-issue
Mar 12, 2026
Merged

Studio: Re-selecting the same file doesn't trigger the import#2768
epeicher merged 1 commit intotrunkfrom
fix/import-same-file-issue

Conversation

@katinthehatsite
Copy link
Copy Markdown
Contributor

Related issues

Fixes STU-1381

How AI was used in this PR

Not used, it is a simple fix

Proposed Changes

This PR ensures that when you use an Import option in Studio and select the same file after cancelling the import with that file once, the state is reset and the import can be initiated.

Testing Instructions

  • Pull the changes from this branch
  • Start Studio with npm start
  • Navigate to Import tab
  • Select a file for import
  • Cancel import
  • Select the same file for import again
  • Confirm that the import can be started

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Mar 11, 2026
@katinthehatsite katinthehatsite requested a review from a team March 11, 2026 19:52
@wpmobilebot
Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 6eda568 vs trunk

site-editor

Metric trunk 6eda568 Diff Change
load 1800.00 ms 1770.00 ms -30.00 ms ⚪ 0.0%

site-startup

Metric trunk 6eda568 Diff Change
siteCreation 6102.00 ms 6150.00 ms +48.00 ms ⚪ 0.0%
siteStartup 3940.00 ms 3942.00 ms +2.00 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

Copy link
Copy Markdown
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix Kat! I have tested it, and I can confirm that it fails in trunk and it works as expected on this branch. LGTM! :shipit:

@epeicher epeicher merged commit 1cb54ee into trunk Mar 12, 2026
10 checks passed
@epeicher epeicher deleted the fix/import-same-file-issue branch March 12, 2026 12:48
@katinthehatsite
Copy link
Copy Markdown
Contributor Author

Thanks for the review and merging the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants