Skip to content

Remove redundant CLI todo action output#2796

Merged
youknowriad merged 2 commits intotrunkfrom
codex/fix-cli-todo-list-updates
Mar 16, 2026
Merged

Remove redundant CLI todo action output#2796
youknowriad merged 2 commits intotrunkfrom
codex/fix-cli-todo-list-updates

Conversation

@nerrad
Copy link
Copy Markdown
Contributor

@nerrad nerrad commented Mar 13, 2026

Related issues

  • Related to CLI todo list rendering cleanup.

How AI was used in this PR

  • Used AI assistance to refactor TodoWrite rendering into a dedicated helper and remove the redundant per-action CLI output. Reviewed the resulting diff and ran local verification before opening and updating this PR.

Proposed Changes

  • stop rendering redundant Added todo and Completed todo lines for CLI todo updates
  • render only the updated todo list snapshot in the CLI output
  • keep the TodoWrite rendering logic isolated in a dedicated helper

Testing Instructions

  • Run npx eslint --fix apps/cli/ai/ui.ts apps/cli/ai/todo-render.ts
  • Run npm run typecheck
  • In the CLI chat UI, trigger a todo list update and confirm only the updated list is shown without redundant action statements

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@nerrad nerrad self-assigned this Mar 13, 2026
@wpmobilebot
Copy link
Copy Markdown
Collaborator

wpmobilebot commented Mar 13, 2026

📊 Performance Test Results

Comparing 0475b67 vs trunk

app-size

Metric trunk 0475b67 Diff Change
App Size (Mac) 1279.97 MB 1279.97 MB 0.00 MB ⚪ 0.0%

site-editor

Metric trunk 0475b67 Diff Change
load 1933 ms 1896 ms 37 ms ⚪ 0.0%

site-startup

Metric trunk 0475b67 Diff Change
siteCreation 7096 ms 7106 ms +10 ms ⚪ 0.0%
siteStartup 3925 ms 3921 ms 4 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@nerrad nerrad closed this Mar 14, 2026
@nerrad nerrad deleted the codex/fix-cli-todo-list-updates branch March 14, 2026 11:54
@nerrad nerrad restored the codex/fix-cli-todo-list-updates branch March 14, 2026 11:55
@nerrad nerrad reopened this Mar 14, 2026
@nerrad nerrad force-pushed the codex/fix-cli-todo-list-updates branch from 64ca9aa to 0475b67 Compare March 14, 2026 12:08
@nerrad nerrad requested review from mtias and youknowriad March 14, 2026 12:09
@@ -0,0 +1,31 @@
import chalk from 'chalk';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that this is the first time we extract some rendering logic from "ui.ts". So I wonder if a "ui/index.ts", "ui/todos.ts" is better

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. To make sure I fully understand though, you mean we'd have ui as a subfolder in the path? So apps/cli/ai/ui/.... If so, that would help organize things a bit better. But can also be done as other helpers/tools are developed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's what I meant, yeah no urgency here

@youknowriad youknowriad merged commit c132dd7 into trunk Mar 16, 2026
11 checks passed
@youknowriad youknowriad deleted the codex/fix-cli-todo-list-updates branch March 16, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants